In the following SP, the @value from settingsCursor never gets set.
The default values are always returned. I have checked the values in
the table and it is indeed as in the SP.

My string comparison is not working. Am I missing something really
simple?

Riyaz

create procedure Get_GrandMarine_Mail_Settings
    @from varchar(64) out,
    @smtp varchar(64) out
as

    set @from = 'riyaz.mans@gmail.com'    -- default email-from
address
    set @smtp = 'mail.dhivehinet.net.mv'     -- default email-smtp
address

    declare @key varchar(64), @value varchar(64)

    declare settingsCursor cursor for select S_Key, S_Value from
T_Settings where S_Key LIKE 'email.%'
    open settingsCursor

    fetch next from settingsCursor into @key, @value
    while (@@FETCH_STATUS = 0)
    begin
        if @key = 'email.from' set @from = @value    -- extract email-
from address
        if @key = 'email.smtp' set @smtp = @value    -- extract email-
smtp address
        fetch next from settingsCursor
    end

    close settingsCursor
    deallocate settingsCursor

    print 'system email from address :: ' + @from
    print 'system email smtp address :: ' + @smtp

go

create table T_Settings (S_Key varchar(50), S_Value varchar(50))

insert into T_Settings values ('email.from','@hotmail.com')
insert into T_Settings values ('email.from','@gmail.com')

insert into T_Settings values ('email.smtp','mail1000.dhivehinet.net.com')
insert into T_Settings values ('email.smtp','mail2000.dhivehinet.net.au')

alter procedure Get_GrandMarine_Mail_Settings
    @from varchar(64) out,
    @smtp varchar(64) out
as
 set nocount on
    set @from = 'riyaz.mans@gmail.com'    -- default email-fromaddress
    set @smtp = 'mail.dhivehinet.net.mv'     -- default email-smtpaddress

    declare @key varchar(64), @value varchar(64)

    declare settingsCursor cursor for select S_Key, S_Value from T_Settings
where S_Key LIKE 'email.%'
    open settingsCursor

    fetch next from settingsCursor into @key, @value
    while (@@FETCH_STATUS = 0)
    begin
        if @key = 'email.from' set @from = @value    -- extract email-from
address
        if @key = 'email.smtp' set @smtp = @value    -- extract email-smtp
address
        fetch next from settingsCursor
    end

    close settingsCursor
    deallocate settingsCursor

    print 'system email from address :: ' + @from
    print 'system email smtp address :: ' + @smtp

go
declare @from_o varchar(64),@smtp_o varchar(64)
exec Get_GrandMarine_Mail_Settings @from=@from_o out ,@smtp=@smtp_o out

select @from_o,@smtp_o